From b494636ac93c5b98487555cceff065336daafa3c Mon Sep 17 00:00:00 2001 From: Dietmar Maurer Date: Thu, 20 Feb 2020 12:38:21 +0100 Subject: [PATCH] PBSPlugin.pm: fix password handling using new on_update_hook --- PVE/Storage/PBSPlugin.pm | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm index b47a188..fcb1597 100644 --- a/PVE/Storage/PBSPlugin.pm +++ b/PVE/Storage/PBSPlugin.pm @@ -171,8 +171,22 @@ sub extract_vzdump_config { sub on_add_hook { my ($class, $storeid, $scfg, %param) = @_; - if (my $password = $param{password}) { - pbs_set_password($scfg, $storeid, $password); + if (defined($param{password})) { + pbs_set_password($scfg, $storeid, $param{password}); + } else { + pbs_delete_password($scfg, $storeid); + } +} + +sub on_update_hook { + my ($class, $storeid, $scfg, %param) = @_; + + return if !exists($param{password}); + + if (defined($param{password})) { + pbs_set_password($scfg, $storeid, $param{password}); + } else { + pbs_delete_password($scfg, $storeid); } }