yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests: archive info: avoid assembling arrays to just de-assemble them directly

Browse Source 
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht
2020-05-15 19:11:48 +02:00
parent 5df46bf2d5
commit c265d42160
1 changed files with 15 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/archive_info_test.pm
View File

@ -75,8 +75,7 @@ for my $virt (sort keys %$bkp_suffix) {
my ($format, $decomp) = $bkp_suffix->{$virt}->@*; my ($format, $decomp) = $bkp_suffix->{$virt}->@*;
for my $suffix (sort keys %$decomp) { for my $suffix (sort keys %$decomp) {
my @arr = ( push @$tests, {
{
description => "Backup archive, $virt, $format.$suffix", description => "Backup archive, $virt, $format.$suffix",
archive => "backup/vzdump-$virt-$vmid-2020_03_30-21_12_40.$format.$suffix", archive => "backup/vzdump-$virt-$vmid-2020_03_30-21_12_40.$format.$suffix",
expected => { expected => {
@ -85,10 +84,7 @@ for my $virt (sort keys %$bkp_suffix) {
'decompressor' => $decomp->{$suffix}, 'decompressor' => $decomp->{$suffix},
'compression' => "$suffix", 'compression' => "$suffix",
}, },
}, };
);
push @$tests, @arr;
} }
} }
@ -103,16 +99,12 @@ my $non_bkp_suffix = {
# create tests for failed matches # create tests for failed matches
for my $virt (sort keys %$non_bkp_suffix) { for my $virt (sort keys %$non_bkp_suffix) {
my $suffix = $non_bkp_suffix->{$virt}; my $suffix = $non_bkp_suffix->{$virt};
foreach my $s (@$suffix) { for my $s (@$suffix) {
my @arr = ( push @$tests, {
{
description => "Failed match: Backup archive, $virt, $s", description => "Failed match: Backup archive, $virt, $s",
archive => "backup/vzdump-$virt-$vmid-2020_03_30-21_12_40.$s", archive => "backup/vzdump-$virt-$vmid-2020_03_30-21_12_40.$s",
expected => "ERROR: couldn't determine format and compression type\n", expected => "ERROR: couldn't determine format and compression type\n",
}, };
);
push @$tests, @arr;
} }
} }