From cc80ed9c00ae239b27ee29a32f012ca09d9669ae Mon Sep 17 00:00:00 2001 From: Wolfgang Link Date: Fri, 23 Jan 2015 10:32:38 +0100 Subject: [PATCH] zfs: move code move parse_volume from ZFSPlugin to ZFSDirPlugin, to avoid duplication Signed-off-by: Wolfgang Link --- PVE/Storage/ZFSDirPlugin.pm | 10 ++++++++++ PVE/Storage/ZFSPlugin.pm | 10 ---------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/PVE/Storage/ZFSDirPlugin.pm b/PVE/Storage/ZFSDirPlugin.pm index e041ffc..08c29c4 100644 --- a/PVE/Storage/ZFSDirPlugin.pm +++ b/PVE/Storage/ZFSDirPlugin.pm @@ -120,6 +120,16 @@ sub zfs_parse_zvol_list { return $list; } +sub parse_volname { + my ($class, $volname) = @_; + + if ($volname =~ m/^(((base|vm)-(\d+)-\S+)\/)?((base)?(vm)?-(\d+)-\S+)$/) { + return ('images', $5, $8, $2, $4, $6); + } + + die "unable to parse zfs volume name '$volname'\n"; +} + # virtual zfs methods (subclass can overwrite them) sub zfs_request { diff --git a/PVE/Storage/ZFSPlugin.pm b/PVE/Storage/ZFSPlugin.pm index 7e21a6d..a5e3fb2 100644 --- a/PVE/Storage/ZFSPlugin.pm +++ b/PVE/Storage/ZFSPlugin.pm @@ -207,16 +207,6 @@ sub options { # Storage implementation -sub parse_volname { - my ($class, $volname) = @_; - - if ($volname =~ m/^(((base|vm)-(\d+)-\S+)\/)?((base)?(vm)?-(\d+)-\S+)$/) { - return ('images', $5, $8, $2, $4, $6); - } - - die "unable to parse zfs volume name '$volname'\n"; -} - sub path { my ($class, $scfg, $volname) = @_;