From d0eaf18571a139025b792a9f27f9fc13216a5e9d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
Date: Tue, 22 Sep 2020 08:56:13 +0200
Subject: [PATCH] zfs: rollback: improve error message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

we don't even know whether $snap exists at all, so the old variant could
be rather misleading..

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 PVE/Storage/ZFSPoolPlugin.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
index 6fa9127..7c180ea 100644
--- a/PVE/Storage/ZFSPoolPlugin.pm
+++ b/PVE/Storage/ZFSPoolPlugin.pm
@@ -476,9 +476,8 @@ sub volume_rollback_is_possible {
     die "can't rollback, no snapshots exist at all\n"
 	if !defined($recentsnap);
 
-    if ($snap ne $recentsnap) {
-	die "can't rollback, more recent snapshots exist\n";
-    }
+    die "can't rollback, '$snap' is not most recent snapshot\n"
+	if $snap ne $recentsnap;
 
     return 1;
 }