yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

btrfs: make NOCOW optional

Browse Source 
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Wolfgang Bumiller
2021-06-22 14:18:23 +02:00
committed by Thomas Lamprecht
parent a0e3e224ea
commit d3c5cf2487
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
PVE/Storage/BTRFSPlugin.pm
View File

@ -46,6 +46,19 @@ sub plugindata {
}; };
} }
sub properties {
return {
nocow => {
description => "Set the NOCOW flag on files."
. " Disables data checksumming and causes data errors to be unrecoverable from"
. " while allowing direct I/O. Only use this if data does not need to be any more"
. " safe than on a single ext4 formatted disk with no underlying raid system.",
type => 'boolean',
default => 0,
},
};
}
sub options { sub options {
return { return {
path => { fixed => 1 }, path => { fixed => 1 },
@ -56,6 +69,7 @@ sub options {
content => { optional => 1 }, content => { optional => 1 },
format => { optional => 1 }, format => { optional => 1 },
is_mountpoint => { optional => 1 }, is_mountpoint => { optional => 1 },
nocow => { optional => 1 },
# TODO: The new variant of mkdir with `populate` vs `create`... # TODO: The new variant of mkdir with `populate` vs `create`...
}; };
} }
@ -311,7 +325,7 @@ sub alloc_image {
} elsif ($fmt eq 'raw') { } elsif ($fmt eq 'raw') {
sysopen my $fh, $path, O_WRONLY | O_CREAT | O_EXCL sysopen my $fh, $path, O_WRONLY | O_CREAT | O_EXCL
or die "failed to create raw file '$path' - $!\n"; or die "failed to create raw file '$path' - $!\n";
chattr($fh, ~FS_NOCOW_FL, FS_NOCOW_FL); chattr($fh, ~FS_NOCOW_FL, FS_NOCOW_FL) if $scfg->{nocow};
truncate($fh, $size * 1024) truncate($fh, $size * 1024)
or die "failed to set file size for '$path' - $!\n"; or die "failed to set file size for '$path' - $!\n";
close($fh); close($fh);