yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

storage: remove $running param from volume_snapshot

Browse Source 
not needed anymore after change in qemu-server

Signed-off-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
This commit is contained in:
Alexandre Derumier
2025-07-16 08:31:53 +02:00
committed by Wolfgang Bumiller
parent 4ef8ab60f6
commit e17a33794c
10 changed files with 15 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/PVE/Storage/Plugin.pm
View File

@ -1272,7 +1272,7 @@ sub volume_resize {
}
sub volume_snapshot {
my ($class, $scfg, $storeid, $volname, $snap, $running) = @_;
my ($class, $scfg, $storeid, $volname, $snap) = @_;
if ($scfg->{'external-snapshots'}) {
@ -1280,18 +1280,14 @@ sub volume_snapshot {
my $vmid = ($class->parse_volname($volname))[2];
if (!$running) {
#rename volume unless qemu has already done it for us
$class->rename_snapshot($scfg, $storeid, $volname, 'current', $snap);
}
#rename volume unless qemu has already done it for us
$class->rename_snapshot($scfg, $storeid, $volname, 'current', $snap);
eval { alloc_backed_image($class, $storeid, $scfg, $volname, $snap) };
if ($@) {
warn "$@ \n";
#if running, the revert is done by qemu with blockdev-reopen
if (!$running) {
eval { $class->rename_snapshot($scfg, $storeid, $volname, $snap, 'current'); };
warn $@ if $@;
}
eval { $class->rename_snapshot($scfg, $storeid, $volname, $snap, 'current'); };
warn $@ if $@;
die "can't allocate new volume $volname with $snap backing image\n";
}