From e4d56f096ed28761d6b9a9e348be0fc682928040 Mon Sep 17 00:00:00 2001 From: Lorenz Stechauner Date: Tue, 31 Aug 2021 12:16:30 +0200 Subject: [PATCH] status: remove sleep(1) in file upload this racey sleep(1) is only there for legacy reasons: because we don't use apache anymore and only emulate its behabiour regarding removing temp files, this is under our own control now and so we can improve this whole situation. this change requires a pve-http-server version, in which the tmpfile gets not automatically removed anymore. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index fd82e53..e12b62a 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage/Status.pm @@ -498,14 +498,7 @@ __PACKAGE__->register_method ({ print "finished file import successfully\n"; }; - my $upid = $rpcenv->fork_worker('imgcopy', undef, $user, $worker); - - # apache removes the temporary file on return, so we need - # to wait here to make sure the worker process starts and - # opens the file before it gets removed. - sleep(1); - - return $upid; + return $rpcenv->fork_worker('imgcopy', undef, $user, $worker); }}); __PACKAGE__->register_method({