yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cephconfig: change code style inside config writer

Browse Source 
This commit changes the code style of subroutine `write_ceph_config`
to match our style guide [0] more.

Furthermore, the repeated calls to the inner subroutine are replaced
with a loop, while the regular expressions used by the inner `sub` are
now quoted with `qr` to prevent any accidental mis-quotings in the
future.

[0]: https://pve.proxmox.com/wiki/Perl_Style_Guide

Signed-off-by: Max Carrara <m.carrara@proxmox.com>
Tested-by: Friedrich Weber <f.weber@proxmox.com>
This commit is contained in:
Max Carrara
2024-04-02 16:55:13 +02:00
committed by Fabian Grünbichler
parent 10facd3793
commit e8dbfc506c
1 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/PVE/CephConfig.pm
View File

@ -65,28 +65,35 @@ sub write_ceph_config {
my $cond_write_sec = sub { my $cond_write_sec = sub {
my $re = shift; my $re = shift;
foreach my $section (sort keys %$cfg) { for my $section (sort keys $cfg->%*) {
next if $section !~ m/^$re$/; next if $section !~ m/^$re$/;
$out .= "[$section]\n"; $out .= "[$section]\n";
foreach my $key (sort keys %{$cfg->{$section}}) { for my $key (sort keys $cfg->{$section}->%*) {
$out .= "\t $key = $cfg->{$section}->{$key}\n"; $out .= "\t $key = $cfg->{$section}->{$key}\n";
} }
$out .= "\n"; $out .= "\n";
} }
}; };
&$cond_write_sec('global'); my @rexprs = (
&$cond_write_sec('client'); qr/global/,
qr/client/,
&$cond_write_sec('mds'); qr/mds/,
&$cond_write_sec('mon'); qr/mon/,
&$cond_write_sec('osd'); qr/osd/,
&$cond_write_sec('mgr'); qr/mgr/,
&$cond_write_sec('mds\..*'); qr/mds\..*/,
&$cond_write_sec('mon\..*'); qr/mon\..*/,
&$cond_write_sec('osd\..*'); qr/osd\..*/,
&$cond_write_sec('mgr\..*'); qr/mgr\..*/,
);
for my $re (@rexprs) {
$cond_write_sec->($re);
}
return $out; return $out;
} }