Commit Graph

20 Commits

Author SHA1 Message Date
0a2f75ffd6 esxi: deactivate storage if config gets updated
to ensure that the next access actually uses the updated config for
accessing the remote ESXi, for both manifest API and FUSE mount.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-03-13 15:29:35 +01:00
68f3ec3f8b esxi: clean-up state-dir in deactivate storage
to ensure we always query a new one on quick add-delete-add cycles.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-03-13 15:29:35 +01:00
72418e2f05 esxi: deactivate storage on deletion from config
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-03-13 15:29:35 +01:00
2ff6f99c60 esxi: add 'skip-cert-verification' option
following pve-esxi-import-tools's commits:
3ee5c3b ("esxi-folder-fuse: add --insecure option")
c292c67 ("listvms.py: add --insecure parameter, verify cert by
          default")
34c87be ("rename --insecure option to --skip-cert-verification")

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 [ TL: rename 'insecure' to 'skip-cert-verification' to better convey
   what it means ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-03-13 15:29:35 +01:00
4f50a578f4 import: rework plugin api to not need a blessed object
does not really make sense, and if the plugin wants that, it can still
be done, like we do here for the ESXiPlugin

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2024-03-13 15:29:35 +01:00
10b5874078 esxi: add disk capacity to import metadata
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:29:35 +01:00
1128100569 esxi: warn if the guest was running
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:29:35 +01:00
aba709f247 esxi: add helper to get vm from manifest for vmx path
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:29:35 +01:00
99ace9d447 esxi: let manifest file expire after 60s
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 [ TL: fix wrong comparison with >= and avoid undef warning if file
   does not yet exist at all ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-03-13 15:29:35 +01:00
814bde1958 esxi: drop unused sub methods
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
 [ TL: squash removal of both subs into one commit ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-03-13 15:29:35 +01:00
1a94dceb6f api: import-metadata: make warnings structured & merge ignored-volumes
This allows the frontends to translate them and avoids somewhat
duplicated info by having some warnings explicitly (ignored-volumes)
while others are in the warnings array.

By passing along the key and the value the frontend can also show the
warnings in-line, e.g. by marking a disk-entry in a grid as having
potential problems.

Ideally we'd have a central list of known types used for the API
return schema enum and to check when calling the $warn closure, but as
we only got three warnings keep this as is and only add a comment.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-03-13 15:29:35 +01:00
da513e260c esxi plugin: do not support the images content-type
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-03-13 15:29:35 +01:00
dde640eda7 esxi plugin: adapt to new libexec path for helpers
and rename the name of the constant for the FUSE tool, as otherwise it
sounds like this was the mountpoint to be used

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2024-03-13 15:29:35 +01:00
5e934933ec esxi import: deal with serial devices
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:29:35 +01:00
fd16d98451 add source field to import-metadata
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:29:35 +01:00
203d73baf9 add a warnings array to import-metadata
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:29:35 +01:00
a3271a47ca esxi: improve scsihw detection
we should actually keep the scsihw even with eg. linux VMs as they
might not have virtio/... in their initrd and then fail to boot

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:29:35 +01:00
728c08b2f0 esxi: separate disks and network
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:29:35 +01:00
763a2292f3 import: return skipped/ignored volumes in get_create_args
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:29:35 +01:00
a171036789 add ESXi plugin for import and wire-it up to a new get_guest_import plugin fn
The get_guest_import fn is currently a private/internal API and should
not yet be exposed as a public part of the storage API.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2024-03-13 15:17:55 +01:00