ebec84ff87
fix #6224 : disks: get: set timeout for retrieval of SMART stat data
...
In rare scenarios, `smartctl` takes up to 60 seconds to timeout for SCSI
commands to be completed, as reported in our user forum [0] and bugzilla
[1]. It seems that USB drives handled by the USB Attached SCSI (UAS)
kernel module are more likely to be affected by this [2], but is more of
a case-by-case situation.
Therefore, set a more reasonable timeout of 10 seconds, so that callers
don't have to wait too long or seem unresponsive (e.g. Node Disks view
in the WebGUI).
[0] https://forum.proxmox.com/threads/164799/
[1] https://bugzilla.proxmox.com/show_bug.cgi?id=6224
[2] https://www.smartmontools.org/wiki/SAT-with-UAS-Linux
Signed-off-by: Daniel Kral <d.kral@proxmox.com >
Reviewed-by: Max Carrara <m.carrara@proxmox.com >
Link: https://lore.proxmox.com/20250415071123.36921-3-d.kral@proxmox.com
2025-11-14 00:29:06 +01:00
b6c18e9116
disks: get: separate error path for retrieving SMART data
...
Make the subroutine get_smart_data() die with the error message from
running the `smartctl` command before. This is in preparation for the
next patch, which makes that command fail in certain scenarios.
Signed-off-by: Daniel Kral <d.kral@proxmox.com >
Link: https://lore.proxmox.com/20250415071123.36921-2-d.kral@proxmox.com
2025-11-14 00:28:27 +01:00
5b949979f7
disks: add a guard possible nonexistent field
...
When running
pveceph osd create <device>
one would get one or two warnings:
Use of uninitialized value in pattern match (m//) at /usr/share/perl5/PVE/Diskmanage.pm line 317.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com >
Link: https://lore.proxmox.com/20251024121309.1253604-1-m.sandoval@proxmox.com
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com >
2025-11-14 00:16:36 +01:00
5a66c27cc6
auto-format code using perltidy with Proxmox style guide
...
using the new top-level `make tidy` target, which calls perltidy via
our wrapper to enforce the desired style as closely as possible.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com >
2025-06-11 10:03:21 +02:00
8a183b5db2
disk management: account for leading white space in serial number
...
some manufacturer seem to report leading white space in the
`ID_SERIAL_SHORT` field. the regex failed here, as it just didn't
match the whitespace at all.
reported on the forum:
https://forum.proxmox.com/threads/nvme-drive-serial-unknown.163480/#post-754953
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com >
Link: https://lore.proxmox.com/20250312083819.15379-1-s.sterz@proxmox.com
2025-04-06 21:18:14 +02:00
e1348a2792
disks: get: add osdid-list return parameter
...
It is possible to run multiple OSD daemons on one disk. The new
'osdid-list' parameter returns an array of all OSD IDs found on the
disk.
The old 'osdid' parameter is kept for compatibility. We might want to
deprecate / remove it in the future.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com >
2023-11-13 16:48:08 +01:00
a2242b41fc
separate packaging and source build system
...
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com >
2023-05-24 16:20:27 +02:00
