Silverfish/proton-bridge
1
0
Fork 1
mirror of https://github.com/ProtonMail/proton-bridge.git synced 2025-12-10 12:46:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: only set ContentID for inline attachments

Browse Source
This commit is contained in:
James Houlahan
2020-12-09 15:08:48 +01:00
parent 363f553d3c
commit 25c1014ab0
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/message/parser.go
View File

@ -510,7 +510,11 @@ func parseAttachment(h message.Header) (*pmapi.Attachment, error) {
}
}
att.ContentID = strings.Trim(h.Get("Content-Id"), " <>")
// Only set ContentID if it should be inline;
// API infers content disposition based on whether ContentID is present.
if disp, _, err := h.ContentDisposition(); err == nil && disp == "inline" {
att.ContentID = strings.Trim(h.Get("Content-Id"), " <>")
}
return att, nil
}

1
unreleased.md
View File

@ -21,3 +21,4 @@ Changelog [format](http://keepachangelog.com/en/1.0.0/)
### Changed
* GODT-389 Prefer `From` header instead of `MAIL FROM` address.
* GODT-898 Only set ContentID for inline attachments.