yesBad/proton-bridge
1
0
Fork 0
forked from Silverfish/proton-bridge
Code Actions Activity

fix(GODT-2813): Write new vault to temporary file first

Browse Source 
Do not immediately overwrite the old vault with new data. If something
goes wrong, we at least maintain on previously valid state.
This commit is contained in:
Leander Beernaert
2023-07-18 15:37:16 +02:00
parent bc66841cdc
commit 110286b81c
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/vault/vault.go
View File

@ -416,7 +416,17 @@ func (vault *Vault) modUnsafe(fn func(data *Data)) error {
vault.enc = enc
return os.WriteFile(vault.path, vault.enc, 0o600)
tmpFile := vault.path + ".tmp"
if err := os.WriteFile(tmpFile, vault.enc, 0o600); err != nil {
return fmt.Errorf("failed write new vault to disk: %w", err)
}
if err := os.Rename(tmpFile, vault.path); err != nil {
return fmt.Errorf("failed to overwrite old vault data: %w", err)
}
return nil
}
func (vault *Vault) getUser(userID string) UserData {