yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests: archive info: code cleanup

Browse Source 
We could also do a hash array slice, like:
> my ($archive, $expected, $description) = $tt->@{'archive', 'expected', 'description'};

But as none are optional lets just access values directly..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht
2020-05-15 18:57:37 +02:00
parent 63e892950b
commit 3dde6a9cb9
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/archive_info_test.pm
View File

@ -119,16 +119,12 @@ foreach my $virt (keys %$non_bkp_suffix) {
plan tests => scalar @$tests;
# run through tests array
foreach my $tt (@$tests) {
my $description = $tt->{description};
my $archive = $tt->{archive};
my $expected = $tt->{expected};
my $got;
eval { $got = PVE::Storage::archive_info($archive) };
for my $tt (@$tests) {
my $got = eval { PVE::Storage::archive_info($tt->{archive}) };
$got = $@ if $@;
is_deeply($got, $expected, $description) || diag(explain($got));
is_deeply($got, $tt->{expected}, $tt->{description}) || diag(explain($got));
}
done_testing();