pbs: autogen key: rename old one if existing
it could be debated do have some security implications and that deletion is safer, but key deletion is a pretty hairy thing. Should be documented, and people just should use delete instead of autogen if they want to "destroy" a key. Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
@ -371,6 +371,9 @@ sub prune_backups {
|
||||
my $autogen_encryption_key = sub {
|
||||
my ($scfg, $storeid) = @_;
|
||||
my $encfile = pbs_encryption_key_file_name($scfg, $storeid);
|
||||
if (-f $encfile) {
|
||||
rename $encfile, "$encfile.old";
|
||||
}
|
||||
my $cmd = ['proxmox-backup-client', 'key', 'create', '--kdf', 'none', $encfile];
|
||||
run_command($cmd, errmsg => 'failed to create encryption key');
|
||||
return PVE::Tools::file_get_contents($encfile);
|
||||
|
||||
Reference in New Issue
Block a user