yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix #3894: cast 'size' and 'used' to integer

Browse Source 
Perl's automatic conversion can lead to integers being converted to
strings, for example by matching it in a regex.

To make sure we always return an integer in the API call, add an
explicit cast to integer.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
This commit is contained in:
Mira Limbeck
2022-02-18 09:58:26 +01:00
committed by Thomas Lamprecht
parent 3363fcf65e
commit 7f30857519
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
PVE/API2/Storage/Content.pm
View File

@ -139,7 +139,9 @@ __PACKAGE__->register_method ({
foreach my $item (@$vollist) {
eval { PVE::Storage::check_volume_access($rpcenv, $authuser, $cfg, undef, $item->{volid}); };
next if $@;
$item->{vmid} = int($item->{vmid}) if (defined($item->{vmid}));
$item->{vmid} = int($item->{vmid}) if defined($item->{vmid});
$item->{size} = int($item->{size}) if defined($item->{size});
$item->{used} = int($item->{used}) if defined($item->{used});
push @$res, $item;
}
@ -326,8 +328,8 @@ __PACKAGE__->register_method ({
my $entry = {
path => $path,
size => $size,
used => $used,
size => int($size), # cast to integer in case it was changed to a string previously
used => int($used),
format => $format,
};