yesBad/pve-storage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scan_cifs: pass user/pass over environment

Browse Source 
As command line argument they are readable by ever user in the same
PID namespace.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht
2020-06-30 15:15:08 +02:00
parent fd55f51efa
commit afaa98f10f
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
PVE/Storage.pm
View File

@ -1196,13 +1196,12 @@ sub scan_cifs {
# we only support Windows 2012 and newer, so just use smb3
my $cmd = ['/usr/bin/smbclient', '-m', 'smb3', '-d', '0', '-L', $server];
if (defined($user)) {
die "password is required\n" if !defined($password);
push @$cmd, '-U', "$user\%$password";
} else {
push @$cmd, '-N';
}
push @$cmd, '-N' if !defined($user);
push @$cmd, '-W', $domain if defined($domain);
die "password is required\n" if defined($user) && !defined($password);
local $ENV{USER} = $user if defined($user);
local $ENV{PASSWD} = $password if defined($password);
my $res = {};
my $err = '';